Enhance read Functionality to Support Complex HCL Objects with Fallback #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshkanYarmoradi
requested review from
tcnksm,
slewiskelly,
dtan4,
yanolab and
ryotafuwa-dev
as code owners
…remove unused cty.Value logic
…d add error handling for unsupported types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This pull request improves the read functionality to handle complex HCL objects. If the parser cannot evaluate the object, it falls back to returning the raw string representation of the object.
WHY
The current implementation fails to read complex HCL objects with invalid syntax or nested structures, causing errors. This enhancement ensures that even if parsing fails, the raw string representation is returned, allowing users to inspect and work with the data effectively.