Skip to content

[WC-2835]: RTE implementation of Quill-Table-Better #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Apr 22, 2025
Merged

[WC-2835]: RTE implementation of Quill-Table-Better #1506

merged 28 commits into from
Apr 22, 2025

Conversation

samuelreichert
Copy link
Contributor

Pull request type

Description

@samuelreichert samuelreichert force-pushed the feat/WC-2835-RTE-table branch 3 times, most recently from a42830a to 3a4ce62 Compare March 24, 2025 08:28
@samuelreichert samuelreichert force-pushed the feat/WC-2835-RTE-table branch from 3a4ce62 to 8b801ae Compare March 27, 2025 15:40
@samuelreichert samuelreichert marked this pull request as ready for review March 28, 2025 08:40
@samuelreichert samuelreichert requested a review from a team as a code owner March 28, 2025 08:40
@samuelreichert samuelreichert force-pushed the feat/WC-2835-RTE-table branch 2 times, most recently from ec3f9c0 to 27df955 Compare April 9, 2025 12:29
gjulivan
gjulivan previously approved these changes Apr 9, 2025
View reviewed changes
@samuelreichert samuelreichert force-pushed the feat/WC-2835-RTE-table branch 2 times, most recently from 4287b89 to 78d35dd Compare April 15, 2025 12:50
samuelreichert and others added 13 commits April 17, 2025 13:16
@samuelreichert
test(rich-text): update failing snapshot
671b0f9
@samuelreichert
fix(quill-table-better): replace document event listeners with quill.…
3e8aa02 
…root event listeners
@samuelreichert
feat(rich-text): add new icons to RichTextIcons.scss
b533097
@samuelreichert
fix(table-better): replace SVG icons with CSS classes for table menus…
9b6de57 
… and properties
@samuelreichert
fix(quill-table-better): remove unused SVG icons for table formatting
e341939
@samuelreichert
fix(rich-text): update RichTextIconFont.woff2 to improve icon rendering
cc560aa
@samuelreichert
fix(rich-text): add quill-table-better to ignored files in ESLint config
9462175
@leonardomendix @samuelreichert
test(rich-text): update e2e screenshot
ee8b636
@samuelreichert
feat(rich-text): add tableBetter property to custom basic mode
d004ef0
@samuelreichert
feat(quill-table-better): add dropdown icon separately to table prope…
4e69f80 
…rties form
@samuelreichert
fix(table-better): update event listeners to use window.document for …
b62fa11 
…drag operations
@samuelreichert
feat(table-better): enhance menu item structure by adding an icon con…
b8612f1 
…tainer
@samuelreichert
fix(rich-text): ensure tableBetter property is set in default props
873d8fd
@samuelreichert samuelreichert force-pushed the feat/WC-2835-RTE-table branch from 6cd4f6c to 873d8fd Compare April 17, 2025 11:16
leonardomendix
leonardomendix previously approved these changes Apr 17, 2025
View reviewed changes
gjulivan
gjulivan previously approved these changes Apr 17, 2025
View reviewed changes
@samuelreichert samuelreichert dismissed stale reviews from gjulivan and leonardomendix via 64143dd April 18, 2025 08:02
@gjulivan gjulivan merged commit b042f0c into main Apr 22, 2025
16 checks passed
@gjulivan gjulivan deleted the feat/WC-2835-RTE-table branch April 22, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0b1n r0b1n r0b1n approved these changes

@gjulivan gjulivan gjulivan approved these changes

@leonardomendix leonardomendix leonardomendix left review comments

Assignees
No one assigned
Labels
rich-text-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuelreichert @r0b1n @gjulivan @leonardomendix