This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Change unix precision to seconds for timestamp property #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timestamp property in AMQP 0-9-1 is defined as a 64bit Unix timestamp, which is seconds since 1970/1/1 For reference -> rabbitmq/rabbitmq-message-timestamp#16 (comment) This causes issues while reading in some of the client libraries which assume that the value is in seconds & parses this value incorrectly Example, java client library -> https://github.com/rabbitmq/rabbitmq-java-client/blob/23e7ba0e96d383c80f8da2fb23786a1111854f9a/src/main/java/com/rabbitmq/client/impl/ValueReader.java#L266
sakshamgupta05
requested review from
akoutmos,
mkorszun,
Shemeikka,
spier and
vorce
as code owners
|
LGTM, but maybe needs to wait for a major version bump as it's clearly going to be a Breaking Change. Although I expect many people are not running into this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timestamp property in AMQP 0-9-1 is defined as a 64bit Unix timestamp, which is seconds since 1970/1/1
For reference -> rabbitmq/rabbitmq-message-timestamp#16 (comment)
This causes issues while reading in some of the client libraries which assume that the value is in seconds & parses this value incorrectly
Example, java client library -> https://github.com/rabbitmq/rabbitmq-java-client/blob/23e7ba0e96d383c80f8da2fb23786a1111854f9a/src/main/java/com/rabbitmq/client/impl/ValueReader.java#L266