Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gtk #1

Closed
wants to merge 12 commits into from
Closed

Update gtk #1

wants to merge 12 commits into from

Conversation

melroy89
Copy link
Owner

@melroy89 melroy89 commented Sep 15, 2021

Updating the whole GTK3 & Gtkmm3 stack. Including all dependencies. Static & shared builds.

Must:

  • Successfully build the Gtkmm package as well (C++ bindings of GTK3)
  • Download & Install meson in MXE
  • Clean-up all the code (remove all dead-code/commented out code)
  • Fix post cross-compilation GTK, using the executable: glib-compile-schemas
  • Solve weird performance issues under Windows (this was because of Glib)
  • Validate a working hello world example (in C language)
  • Validate against a Vala app
  • Validate against a C++ app (example app)
  • Fix download warnings (We fixed most of the download warnings regarding back-up URLs, only the once out-of-our control aren't fixed)
  • new GTK3 release (3.24.32) is now available and is working (fixes Windows builds & GCC11 builds)!

Out-of-scope:

@melroy89
Copy link
Owner Author

melroy89 commented Oct 27, 2021

@v1993 I applied your PR into this branch already.

Are you sure we can use MXE plugins during the build within the makefiles? Since the use-case of this plugin is to build via: x86_64-w64-mingw32.static-meson.. But the newer GTK versions and their dependency packages can ONLY be build via Meson.

So, how do you want to call the meson plugin in the makefiles? Eg. within the src/atk.mk file (as an example).

@melroy89
Copy link
Owner Author

@v1993 If collaboration makes it easier, you can chat with me via Telegram: https://t.me/melroyvandenberg if you want

@v1993
Copy link
Collaborator

v1993 commented Oct 27, 2021

Well, if you take a look at wrapper script, it becomes apparent that it just calls meson with suitable arguments. I've managed to build few GTK things manually with it, so it's very well doable.

It's been a while since I did that, but the idea is as follows:

  1. Move meson-wrapper from plugins to src.
  2. Make all projects that use meson depend on it.
  3. I think calls to meson should look like '$(PREFIX)/bin/$(TARGET)-meson' _build ..

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

@Danger89 FYI - I'm currently working on this. I've managed to make glib build use meson wrapper.

Are you still interested in this project?

@melroy89
Copy link
Owner Author

melroy89 commented Dec 4, 2021

@Danger89 FYI - I'm currently working on this. I've managed to make glib build use meson wrapper.

Are you still interested in this project?

Yes. I'm definitely still interested in this project. I really want to upgrade MXE to the latest GTK version. Thank you for helping me out here!!

Edit: I also added the gobject introspection project to a new .mk file. I think we need this project for building GTK.

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

I'm trying to build atk for x86_64-w64-mingw32.static target while using gcc11 plugin. Simply removing gobject-introspection from its deps makes it build, but then build fails with the following odd error:


Failed to build package atk for target x86_64-w64-mingw32.static!
------------------------------------------------------------
/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/atk/libatk-1.0.a(meson-generated_.._atk-enum-types.c.obj):atk-enum-types:(.pdata+0x0): dangerous relocation: collect2: fatal error: ld terminated with signal 11 [Segmentation fault], core dumped
compilation terminated.
linking of temporary binary failed: Command '['x86_64-linux-gnu-gcc', '-o', '/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/tmp-introspect0i73v4i3/Atk-1.0', '/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/tmp-introspect0i73v4i3/Atk-1.0.o', '-L.', '-Wl,-rpath,.', '-Wl,--no-as-needed', '-L/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/atk', '-Wl,-rpath,/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/atk', '-L/home/v/compile/mxe/usr/x86_64-w64-mingw32.static/lib/../lib', '-Wl,-rpath,/home/v/compile/mxe/usr/x86_64-w64-mingw32.static/lib/../lib', '/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/atk/libatk-1.0.a', '-lglib-2.0', '-lintl', '-liconv', '-lws2_32', '-lwinmm', '-lm', '-lpcre', '-lole32', '-lshlwapi', '-lgobject-2.0', '-lffi', '-lgirepository-1.0', '-lgio-2.0', '-lgobject-2.0', '-Wl,--export-dynamic', '-lgmodule-2.0', '-pthread', '-lglib-2.0']' returned non-zero exit status 1.
ninja: build stopped: subcommand failed.

Do you have any idea what could the issue be?

@melroy89
Copy link
Owner Author

melroy89 commented Dec 4, 2021

Well, I can remember I had the same crash in the past as well also during linking of atk. But no, I don't know why or how this happens.

Could this be a bug in ld command? If so, should we downgrade binutils, and try again? or do you think we are missing some library during linking (like the gobject-introspection, just to name one)?

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

This doesn't seem like missing library (that shouldn't segfault, at least). Before my last commit, patched binutils 2.36.1 was used, so I've updated to binutils 2.37 in hopes that would solve the issue. It indeed seems like a bug in binutils to me.

I'll try and see if this happens with older (e.g. standard GCC 5.5.0) GCC as well.

Also, there doesn't seem to be a single thing called "gobject-introspection"? I'm currently looking into it.

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

And it happen with GCC 5.5.0 too. I'm not sure how to progress further with this error.

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

Actually, looking at log, I think I see what the issue is:

[51/52] Generating Atk-1.0.gir with a custom command
FAILED: atk/Atk-1.0.gir 
/usr/bin/g-ir-scanner --no-libtool --namespace=Atk --nsversion=1.0 --warn-all --output atk/Atk-1.0.gir --quiet --c-include=atk/atk.h -DATK_COMPILATION -I/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0/atk -I/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/atk -I./. -I../atk-2.36.0/. -I./atk -I../atk-2.36.0/atk --filelist=/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/atk/libatk-1.0.a.p/Atk_1.0_gir_filelist --include=GObject-2.0 --symbol-prefix=atk --identifier-prefix=Atk --pkg-export=atk --cflags-begin -DG_DISABLE_SINGLE_INCLUDES -DATK_DISABLE_SINGLE_INCLUDES -I/home/v/compile/mxe/usr/x86_64-w64-mingw32.static/include/glib-2.0 -I/home/v/compile/mxe/usr/x86_64-w64-mingw32.static/lib/glib-2.0/include -DPCRE_STATIC -I/home/v/compile/mxe/usr/x86_64-w64-mingw32.static/lib/libffi-3.2.1/include -I/usr/include/gobject-introspection-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include --cflags-end --add-include-path=/usr/share/gir-1.0 --library /home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/atk/libatk-1.0.a -L/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/atk --extra-library=glib-2.0 --extra-library=intl --extra-library=iconv --extra-library=ws2_32 --extra-library=winmm --extra-library=m --extra-library=pcre --extra-library=ole32 --extra-library=shlwapi --extra-library=gobject-2.0 -L/home/v/compile/mxe/usr/x86_64-w64-mingw32.static/lib/../lib --extra-library=ffi --extra-library=girepository-1.0 --sources-top-dirs /home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0/subprojects/ --sources-top-dirs /home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/subprojects/
collect2: fatal error: ld terminated with signal 11 [Segmentation fault], core dumped
compilation terminated.
linking of temporary binary failed: Command '['x86_64-linux-gnu-gcc', '-o', '/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/tmp-introspectrat3agws/Atk-1.0', '/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/tmp-introspectrat3agws/Atk-1.0.o', '-L.', '-Wl,-rpath,.', '-Wl,--no-as-needed', '-L/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/atk', '-Wl,-rpath,/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/atk', '-L/home/v/compile/mxe/usr/x86_64-w64-mingw32.static/lib/../lib', '-Wl,-rpath,/home/v/compile/mxe/usr/x86_64-w64-mingw32.static/lib/../lib', '/home/v/compile/mxe/tmp-atk-x86_64-w64-mingw32.static/atk-2.36.0.build_/atk/libatk-1.0.a', '-lglib-2.0', '-lintl', '-liconv', '-lws2_32', '-lwinmm', '-lm', '-lpcre', '-lole32', '-lshlwapi', '-lgobject-2.0', '-lffi', '-lgirepository-1.0', '-lgio-2.0', '-lgobject-2.0', '-Wl,--export-dynamic', '-lgmodule-2.0', '-pthread', '-lglib-2.0']' returned non-zero exit status 1.
ninja: build stopped: subcommand failed.

It calls gobject-introspection scanner on host, which likely calls host ld, which segfaults when fed with windows binaries.

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

Yes, essentially confirmed that to be the case. Passing -Dintrospection=false makes ATK build just fine.

Now, before adding gobject-introspection into build, we need to figure out how to make its tools work with MXE build (since wine is not an option, this might get tricky).

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

Looking at https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/344, they probably require wine here:

g-ir-compiler dlopens the installed executable, so it must be run with an emulator.

As such, I propose passing -Dintrospection=false, since MXE disallows using wine. This also means we don't actually need to build gobject-introspection tools, or at least don't need to depend on them.

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

Note: I'm currently trying try make gtk3 itself compile! Version 3.24.30 has a bug (it tries to include winpointer.h header that does not exist), so I had to downgrade to 2.24.29.

@melroy89
Copy link
Owner Author

melroy89 commented Dec 4, 2021

That sounds great! Hopefully everything compiles without any errrors.

Note: I was also updating already some C++ bindings, since my GTK app is actually written in C++ :).

@melroy89
Copy link
Owner Author

melroy89 commented Dec 4, 2021

Note: I'm currently trying try make gtk3 itself compile! Version 3.24.30 has a bug (it tries to include winpointer.h header that does not exist), so I had to downgrade to 2.24.29.

Ps. ps. WIth or without Wayland

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

We're compiling for windows. There's no wayland on windows.

@melroy89
Copy link
Owner Author

melroy89 commented Dec 4, 2021

uh yeah.. that's is right... uh... what is my name again?

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

Please try making shared build with my latest commit. Static builds are broken due to issues in libraries (they need patches), but dynamic ones might already work.

@melroy89
Copy link
Owner Author

melroy89 commented Dec 4, 2021

Let me try..

@melroy89
Copy link
Owner Author

melroy89 commented Dec 4, 2021

Owow.

tmp-pango-x86_64-w64-mingw32.shared/pango-1.50.0/meson.build:249:0: ERROR: Git command failed: ['/usr/bin/git', 'clone', '--depth', '1', '--branch', 'master', 'https://github.com/fribidi/fribidi.git', 'fribidi']

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

Should be fixed now.

@melroy89
Copy link
Owner Author

melroy89 commented Dec 4, 2021

This is strange, manually executing /usr/bin/git clone --depth 1 --branch master https://github.com/fribidi/fribidi.git fribidi just works fine.

Also it's strange it says it needs to look for "a fallback subproject for the dependency fribidi". Are we missing a explicit dependency?

@melroy89
Copy link
Owner Author

melroy89 commented Dec 4, 2021

Should be fixed now.

ah never mind. :) Let me try again.

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

Git clone fails because MXE injects library that prevents build scripts from using network (by design). I've fixed this now.

@melroy89
Copy link
Owner Author

melroy89 commented Dec 4, 2021

ow nooo.

Failed to build package gtk3 for target x86_64-w64-mingw32.shared!
------------------------------------------------------------
FAILED: install script '/usr/bin/python3 /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/build-aux/meson/post-install.py 3.0 3.0.0 /opt/mxe/usr/x86_64-w64-mingw32.shared/bin /opt/mxe/usr/x86_64-w64-mingw32.shared/lib /opt/mxe/usr/x86_64-w64-mingw32.shared/share' exit code 1, stopped
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29.build_/po-properties/zh_TW.gmo to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/locale/zh_TW/LC_MESSAGES/gtk30-properties.mo
Compiling GSettings schemas...
Updating icon cache...
Traceback (most recent call last):
  File "/opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/build-aux/meson/post-install.py", line 40, in <module>
    subprocess.call([gtk_update_icon_cache, '-q', '-t' ,'-f',
  File "/usr/lib/python3.8/subprocess.py", line 340, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/usr/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/opt/mxe/usr/x86_64-w64-mingw32.shared/bin/gtk-update-icon-cache'
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/demos/gtk-demo/data/22x22/gtk3-demo.png to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/icons/hicolor/22x22/apps
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/demos/gtk-demo/data/22x22/gtk3-demo-symbolic.symbolic.png to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/icons/hicolor/22x22/apps
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/demos/gtk-demo/data/24x24/gtk3-demo.png to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/icons/hicolor/24x24/apps
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/demos/gtk-demo/data/24x24/gtk3-demo-symbolic.symbolic.png to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/icons/hicolor/24x24/apps
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/demos/gtk-demo/data/32x32/gtk3-demo.png to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/icons/hicolor/32x32/apps
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/demos/gtk-demo/data/32x32/gtk3-demo-symbolic.symbolic.png to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/icons/hicolor/32x32/apps
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/demos/gtk-demo/data/48x48/gtk3-demo.png to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/icons/hicolor/48x48/apps
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/demos/gtk-demo/data/48x48/gtk3-demo-symbolic.symbolic.png to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/icons/hicolor/48x48/apps
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/demos/gtk-demo/data/256x256/gtk3-demo.png to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/icons/hicolor/256x256/apps
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/demos/gtk-demo/data/256x256/gtk3-demo-symbolic.symbolic.png to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/icons/hicolor/256x256/apps
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/demos/gtk-demo/gtk3-demo.desktop to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/applications
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/demos/gtk-demo/org.gtk.Demo.gschema.xml to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/glib-2.0/schemas
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29.build_/gail-3.0.pc to /opt/mxe/usr/x86_64-w64-mingw32.shared/lib/pkgconfig
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29.build_/gdk-3.0.pc to /opt/mxe/usr/x86_64-w64-mingw32.shared/lib/pkgconfig
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29.build_/gdk-win32-3.0.pc to /opt/mxe/usr/x86_64-w64-mingw32.shared/lib/pkgconfig
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29.build_/gtk+-3.0.pc to /opt/mxe/usr/x86_64-w64-mingw32.shared/lib/pkgconfig
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29.build_/gtk+-win32-3.0.pc to /opt/mxe/usr/x86_64-w64-mingw32.shared/lib/pkgconfig
Installing /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/m4macros/gtk-3.0.m4 to /opt/mxe/usr/x86_64-w64-mingw32.shared/share/aclocal
Running custom install script '/usr/bin/meson --internal gettext install --subdir=po --localedir=share/locale --pkgname=gtk30'
Running custom install script '/usr/bin/meson --internal gettext install --subdir=po-properties --localedir=share/locale --pkgname=gtk30-properties'
Running custom install script '/usr/bin/python3 /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/build-aux/meson/post-install.py 3.0 3.0.0 /opt/mxe/usr/x86_64-w64-mingw32.shared/bin /opt/mxe/usr/x86_64->
FAILED: install script '/usr/bin/python3 /opt/mxe/tmp-gtk3-x86_64-w64-mingw32.shared/gtk+-3.24.29/build-aux/meson/post-install.py 3.0 3.0.0 /opt/mxe/usr/x86_64-w64-mingw32.shared/bin /opt/mxe/usr/x86_64-w64-min>
FAILED: meson-install
/usr/bin/meson install --no-rebuild
ninja: build stopped: subcommand failed.
make[1]: *** [Makefile:877: build-only-gtk3_x86_64-w64-mingw32.shared] Error 1
make[1]: Leaving directory '/opt/mxe'

@melroy89
Copy link
Owner Author

melroy89 commented Dec 4, 2021

And indeed. I'm missing the gtk-update-icon-cache, since I only build the Windows x64 exe binary.

Edit: I do not think we need to call this command during a cross-compile..

@v1993
Copy link
Collaborator

v1993 commented Dec 4, 2021

We probably need to exclude that installation step somehow, since it's updating some icons for example program. I'll look into it.

@melroy89
Copy link
Owner Author

melroy89 commented Dec 4, 2021

yeah indeed, this only make sense if you are actually native building GTK at the very least.

@melroy89
Copy link
Owner Author

melroy89 commented Jan 21, 2022

@v1993 Hi! I hope you're doing well.

Any change if you can finish the work (regarding libsoup)? So we can create the PR to the official MXE project?

@mabrand Due to the latest harfbuzz update in the upstream, gtk will not build anymore. And the latest gtk3 release is also not building (read my comment above). It should all be fixed in the latest upcoming GTK3 release. I do not like to create path files for that now, since I fixed that already upstream in GTK3.

@matthiasclasen I really hope GTK3 will create a new release, so we just can successfully cross-buld again (in the current latest releases that is broken).

@melroy89
Copy link
Owner Author

melroy89 commented Feb 26, 2022

Preparing for new GTK3 release of gtk-3-24 branch.

Currently testing using: sudo make gtk3 gtkmm3 gtk3_SOURCE_TREE=/opt/gtk/ -j 16 MXE_TARGETS='x86_64-w64-mingw32.static' (Since gcc11 is default now, no need for the plugin, plus I use the gtk3_SOURCE_TREE option until the new GTK3.24 version)

@melroy89 melroy89 marked this pull request as ready for review February 26, 2022 01:23
@melroy89
Copy link
Owner Author

melroy89 commented Mar 2, 2022

@v1993 Hi :) You want to take a last look at libsoup? I expect gtk3 release this week, so I expect to create a MXE PR anytime soon now 👍🏽

@v1993
Copy link
Collaborator

v1993 commented Mar 4, 2022

Sorry, I'm quite busy with other stuff right now. If something crops up - feel free to ping me, I'll try to answer, but don't expect me to be able to contribute anything major for now.

@melroy89
Copy link
Owner Author

melroy89 commented Mar 4, 2022

Sorry, I'm quite busy with other stuff right now. If something crops up - feel free to ping me, I'll try to answer, but don't expect me to be able to contribute anything major for now.

OK Sure no problem. GTK just released the new GTK version (v3.24.32) where various upstream build issues are solved.

I think it's a big milestone for all of us. 🥳 At least your effort has not been wasted.

@melroy89 melroy89 changed the title Draft: Update gtk Update gtk Mar 4, 2022
@melroy89
Copy link
Owner Author

melroy89 commented Mar 5, 2022

TODO: Fixing patch with tools/patch-tool-mxe sorry..

@melroy89
Copy link
Owner Author

melroy89 commented Mar 5, 2022

PR Created: mxe#2788

@melroy89 melroy89 force-pushed the update_gtk branch 2 times, most recently from 1f7567e to e1e5712 Compare March 27, 2022 13:16
melroy89 added 3 commits April 2, 2022 16:48
Signed-off-by: Melroy van den Berg <[email protected]>
Signed-off-by: Melroy van den Berg <[email protected]>
@melroy89
Copy link
Owner Author

melroy89 commented May 8, 2022

This was a concept pr. This branch is merged upstream. Closing now.

@v1993 again thanks for your time. Hopefully we will speak again some day.

@melroy89 melroy89 closed this May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants