Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task1 #1

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Task1 #1

merged 4 commits into from
Oct 23, 2019

Conversation

meis0n
Copy link
Owner

@meis0n meis0n commented Oct 20, 2019

No description provided.

@AinuraAliieva AinuraAliieva self-requested a review October 21, 2019 08:11
AinuraAliieva
AinuraAliieva reviewed Oct 22, 2019
View reviewed changes
Copy link
Collaborator

@AinuraAliieva AinuraAliieva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Added a couple of comments, among them a small improvement for better understandability and readability.

src/app/core/core.module.ts Outdated Show resolved Hide resolved
AinuraAliieva
AinuraAliieva reviewed Oct 22, 2019
View reviewed changes
Copy link
Collaborator

@AinuraAliieva AinuraAliieva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meis0n the comments did not affect your score but please take a look and implement the improvement in order to merge this PR.

@AinuraAliieva AinuraAliieva merged commit bde1446 into master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AinuraAliieva AinuraAliieva AinuraAliieva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meis0n @AinuraAliieva