Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--accept should skip pager/more utility, allowing non-interactive install #305

Merged
merged 2 commits into from
Apr 24, 2023
Merged

--accept should skip pager/more utility, allowing non-interactive install #305

merged 2 commits into from
Apr 24, 2023

Conversation

bompus
Copy link
Contributor

@bompus bompus commented Apr 24, 2023

Fixes #304

@bompus bompus mentioned this pull request Apr 24, 2023
Merged
@realtime-neil
Copy link
Contributor

That's a fair point, indeed. And the fix looks sensible.

Would you be opposed to adding a test unit for this? I'm envisioning something like

PAGER=less timeout 5 ./path/to/my.run --accept

@bompus
Copy link
Contributor Author

bompus commented Apr 24, 2023

@realtime-neil I don't have the time at the moment, as I've already moved on to other tasks.

megastep
megastep requested changes Apr 24, 2023
View reviewed changes
makeself-header.sh Outdated Show resolved Hide resolved
@megastep megastep merged commit 64e1262 into megastep:master Apr 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megastep megastep megastep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--accept requires key press to exit paged licensetxt
3 participants
@bompus @realtime-neil @megastep