Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 300: delete the contents of $tmpdir after creating it #301

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions makeself-header.sh
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,7 @@ else
eval \$finish
exit 1
}
find "\$tmpdir" -mindepth 1 -delete
fi

location="\`pwd\`"
Expand Down
2 changes: 1 addition & 1 deletion test/suidtest
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ testSuidDoesntGetBroken() {
)
# Create the self extracting that should extract deployedfile
local file_name="$(mktemp -t file_name.XXXXXX)"
"${SUT}" --target "${archive_dir}" "${archive_dir}" "${file_name}" "suid test"
"${SUT}" --notemp --target "${archive_dir}" "${archive_dir}" "${file_name}" "suid test"
assertEquals $? 0
# Target directory now has another file with sudo permissions
# This will get broken because of chown -R
Expand Down
Loading