Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not set title/description to "Deleted video"/ "This video is unavailable" #534

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

vasconsaurus
Copy link
Contributor

Description

This causes issues with similarity matching.

References: CV2-6267

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@vasconsaurus vasconsaurus marked this pull request as ready for review March 19, 2025 18:52
@@ -14,7 +14,8 @@ def oembed_url(_ = nil)
def initialize(url)
super(url)

Yt.configuration.api_key = PenderConfig.get(:google_api_key)
# Yt.configuration.api_key = PenderConfig.get(:google_api_key)
Yt.configuration.api_key = "AIzaSyDn7mOdyoTZFOHVN5HOsOq4L4saj_JkAuA"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this

@vasconsaurus vasconsaurus requested a review from caiosba March 19, 2025 19:45
@vasconsaurus vasconsaurus merged commit 7c7c7b7 into develop Mar 19, 2025
4 checks passed
@vasconsaurus vasconsaurus deleted the 6267-update-set-deleted-info-youtube branch March 19, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants