[CV2-6075] text similarity sync & async call diagrams #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyemeedan
changed the title
caiosba
reviewed
Mar 5, 2025
There was a problem hiding this comment.
There is a typo in recieved, and the questions in the documentation are pertinent. The Check API part is accurate AFAICT. I suggest the title of the diagram states [DRAFT] explicitly, but looks like it's almost there. I appreciate if @computermacgyver can confirm from the Alegre/Presto side.
caiosba
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds markdown documentation files for tracing through the text similarity calls. Although I believe these are accurate (they were written by tracing through the code) it would be great to take another pass through at confirming details
Reference: https://meedan.atlassian.net/browse/CV2-6075