chore(workflows): Use Node 16.14 in CLI workflow #5993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
olivermrbl
changed the title
|
@adrien2p OK with this? |
adrien2p
approved these changes
Jan 4, 2024
|
It is approved man 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use Node version 16.14 in CLI workflow to eliminate an issue with a dependency requiring 16.14 or higher. Our default is 16.10.
This is not an ideal solution, but since we are moving toward Node 18 (and 20), I'd argue it's fine to have it as a temporary workaround for the CI to pass.
The reason for not defaulting to 16.14 for all workflows is that jest version 1.16.11 to 21 ships with a known memory issue, that would cause pipelines to fail.