Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(product, pricing, utils): Transaction issues and reference issues #5533

Merged
merged 29 commits into from
Nov 6, 2023
Merged

feat(product, pricing, utils): Transaction issues and reference issues #5533

merged 29 commits into from
Nov 6, 2023

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Nov 2, 2023 •
edited
Loading

What

  • The transaction decorator has been fixed to get fresh manager before starting a new transaction in order to prevent Unit of works to be re used from the main manager during a transction leading to issues when working with data
  • Inject manager has been reworked too
  • Decorators api re work
  • Fixing repository and services in the product and pricing module to be sure they are using the shared context and using the active manager when needed
  • Update nodejs version in the pipeline to prevent issues with v8 script compilation introduced since 16.11 and fixed in 21

NOTE

jest. + node>16.11<21 have memory issues jestjs/jest#11956

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 104023d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/pricing Patch
@medusajs/product Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 11:07am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 11:07am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 11:07am

@adrien2p adrien2p marked this pull request as ready for review November 2, 2023 16:03
@adrien2p adrien2p requested a review from a team as a code owner November 2, 2023 16:03
@adrien2p
Copy link
Member Author

adrien2p commented Nov 2, 2023

@riqwan could you just check this test FAIL __tests__/product/admin/create-product.ts please 💪

riqwan
riqwan approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

packages/pricing/src/repositories/pricing.ts Show resolved Hide resolved
packages/pricing/src/services/currency.ts Outdated Show resolved Hide resolved
packages/product/src/repositories/product-option.ts Outdated Show resolved Hide resolved
olivermrbl
olivermrbl previously approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl dismissed their stale review November 3, 2023 10:54

I was too quick; tests are failing

@adrien2p
Copy link
Member Author

adrien2p commented Nov 3, 2023

@olivermrbl the next pipe should be good

@adrien2p
Copy link
Member Author

adrien2p commented Nov 3, 2023

@olivermrbl could we merge this one so that we can move forward on the other pr please?

carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrien2p adrien2p merged commit f88d75b into develop Nov 6, 2023
15 checks passed
This was referenced Nov 6, 2023
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@riqwan riqwan Awaiting requested review from riqwan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrien2p @riqwan @carlos-r-l-rodrigues @olivermrbl