Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajout des classes FrDateRecognizer et FrAgeRecognizer corrigées #58

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Ajout des classes FrDateRecognizer et FrAgeRecognizer corrigées #58

wants to merge 4 commits into from

Conversation

cpetresc
Copy link
Collaborator

@cpetresc cpetresc commented Aug 1, 2024

No description provided.

ghisvail
ghisvail reviewed Aug 1, 2024
View reviewed changes
medkit/text/deid.py Outdated Show resolved Hide resolved
ghisvail
ghisvail reviewed Aug 1, 2024
View reviewed changes
medkit/text/deid.py Outdated Show resolved Hide resolved
ghisvail
ghisvail requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@ghisvail ghisvail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good for a first attempt. I left a few comments, some with suggestions ready to be committed (or commented if you disagree, each is its own sub-thread), others with actions required on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghisvail ghisvail ghisvail requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpetresc @ghisvail