[release-0.9] Remove golang.org/x/crypto package Dependency #241
Conversation
Package github.com/Masterminds/sprig imports a golang.org/x/crypto package that we wish to avoid. We remove all the unviersal functions from sprig as two of them, bcrypt and htpasswd use insecure algorithms from golang.org/x/crypto
Add missing and remove unused modules, make vendored copy of dependencies, and verify dependencies have expected content by go mod verify
As of Go 1.16, this function simply calls os.ReadFile, thus we can remove it and simply call os.ReadFile
No changes are needed in the rendet_test.go file for applying the removal of github.com/Masterminds/sprig package
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
It would be important for the |
This is an automated cherry-pick of #239
/assign razo7