adding label on default template #161
Conversation
Signed-off-by: Michael Shitrit <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
/test ? |
|
@mshitrit: The following commands are available to trigger required jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test 4.12-openshift-e2e |
| return []*SelfNodeRemediationTemplate{ | ||
| { | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: resourceDeletionTemplateName, | ||
| Name: defaultTemplateName, | ||
| Labels: templateLabels, |
There was a problem hiding this comment.
just fyi, this is also possible:
Labels: map[string]string {
labels.DefaultTemplate: "",
},
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mshitrit, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold leaving it up to you which PR should be merged first |
mshitrit
changed the title
|
/unhold |
ECOPROJECT-1759
ATM The UI is looking for SNR Template with the default remediation strategy completely hard coded (i.e hard coded for ResourceDeletion).
In order to make the UI more robust and prevent unnecessary changes in the UI when the default Strategy is changed, we'd put a label on the Template with the default strategy instead.