Set Golang version for specifing the correct toolchain #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this specific toolchain we set the minimum requirement for Golang version. 'go command uses its own bundled toolchain when that toolchain is at least as new as the go or toolchain lines in the main module'. https://go.dev/doc/toolchain
Tests can fail due to mistmatch
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
slintes
reviewed
Dec 11, 2024
| @@ -9,7 +9,7 @@ ENVTEST_VERSION ?= v0.0.0-20240112123317-48d9a7b44e54 | |||
| # See https://pkg.go.dev/golang.org/x/tools/cmd/goimports?tab=versions for the last version | |||
| GOIMPORTS_VERSION ?= v0.17.0 | |||
| # See https://github.com/onsi/ginkgo/releases for the last version | |||
| GINKGO_VERSION ?= v2.14.0 | |||
| GINKGO_VERSION ?= v2.22.0 | |||
There was a problem hiding this comment.
Yes, I forgot to add it as part of dbb954b#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R8
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR
Using this specific toolchain we set the minimum requirement for Golang version.
"go command uses its own bundled toolchain when that toolchain is at least as new as the go or toolchain lines in the main module" - https://go.dev/doc/toolchain
Changes made
1.23 -> 1.23.0Which issue(s) this PR fixes
Test plan