Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit Access to the pod's Root File System #136

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Limit Access to the pod's Root File System #136

merged 2 commits into from
Dec 11, 2024

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Oct 14, 2024 •
edited
Loading

Why we need this PR

Limit access to the pod's root file system. An immutable root file system prevents applications from writing to their local disk

Changes made

Set readOnlyRootFilesystem to true

Which issue(s) this PR fixes

Test plan

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

razo7 added 2 commits October 14, 2024 12:17
@razo7
Set readOnlyRootFilesystem to true
3bcdc1a 
An immutable root file system prevents applications from writing to their local disk
@razo7
Run make bundle and apply changes to the bundle container
58dd50a
@razo7
Copy link
Member Author

razo7 commented Oct 14, 2024

/test 4.16-openshift-e2e
/test 4.17-openshift-e2e

1 similar comment
@razo7
Copy link
Member Author

razo7 commented Oct 14, 2024

/test 4.16-openshift-e2e
/test 4.17-openshift-e2e

@razo7
Copy link
Member Author

razo7 commented Nov 5, 2024

/test 4.16-openshift-e2e

@openshift-ci openshift-ci bot added the lgtm label Nov 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 marked this pull request as ready for review November 11, 2024 06:14
@openshift-ci openshift-ci bot requested review from clobrano and slintes November 11, 2024 06:14
@razo7
Copy link
Member Author

razo7 commented Nov 11, 2024

/retest

4 similar comments
@razo7
Copy link
Member Author

razo7 commented Nov 11, 2024

/retest

@razo7
Copy link
Member Author

razo7 commented Nov 12, 2024

/retest

@razo7
Copy link
Member Author

razo7 commented Nov 13, 2024

/retest

@razo7
Copy link
Member Author

razo7 commented Nov 18, 2024

/retest

@razo7
Copy link
Member Author

razo7 commented Nov 18, 2024

/hold

@razo7
Copy link
Member Author

razo7 commented Dec 9, 2024

/retest

@razo7
Copy link
Member Author

razo7 commented Dec 10, 2024

wait for openshift/release#58821 for testing it on OCP 4.18.

@razo7
Copy link
Member Author

razo7 commented Dec 10, 2024

/retest

@razo7
Copy link
Member Author

razo7 commented Dec 10, 2024

/unhold

@razo7
Copy link
Member Author

razo7 commented Dec 10, 2024

/retest

2 similar comments
@razo7
Copy link
Member Author

razo7 commented Dec 10, 2024

/retest

@razo7
Copy link
Member Author

razo7 commented Dec 11, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 2bbe58f into medik8s:main Dec 11, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clobrano clobrano Awaiting requested review from clobrano

@slintes slintes Awaiting requested review from slintes

Assignees

@slintes slintes

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razo7 @slintes