Automate community bundle creation #132
Conversation
All the other operators' Makefile use CSV in place of BUNDLE_CSV Signed-off-by: Carlo Lobrano <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
There is a problem with the OCP_VERSION used in the CI /hold |
Add CI automation to create bundles for K8S and OKD Removed "replaces" field from config as the field is only required in OKD.
clobrano
force-pushed
the
automate-community-bundle-0
branch
from
d9de553 to
34feda6
Compare
fixed. I needed some sleep evidently /unhold |
|
/test 4.16-openshift-e2e |
| @@ -20,6 +20,12 @@ GO_VERSION = 1.20 | |||
| ENVTEST_K8S_VERSION = 1.28 | |||
| # See https://github.com/slintes/sort-imports/releases for the last version | |||
| SORT_IMPORTS_VERSION = v0.2.1 | |||
| # OCP Version: for OKD bundle community | |||
| OCP_VERSION ?= 4.12 | |||
There was a problem hiding this comment.
Do we need this here? It's set by CI, not?
There was a problem hiding this comment.
I remember a discussion where we ended up wanting at least a default version set 🤷
There was a problem hiding this comment.
btw, some other operators have a bug here (SNR and MDR, IIRC), because they assign the value without the ?.
There was a problem hiding this comment.
aaand I remembered incorrectly... sorry 😓
at the time of the discussion the variable was useful because we didn't have this CI
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why we need this PR
The bundle CSV needs to set the PREVIOUS_VERSION variable manually (for "replaces" field).
Changes made
Rework CI to include a manual workflow to release to OKD and K8S Hub, allowing to set some variables.
Which issue(s) this PR fixes
Test plan