Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kube-rbac-proxy image to v0.15.0 and disable HTTP/2 #104

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Oct 24, 2023

  • update kube-rbac-proxy to v0.15.0
  • disable HTTP/2 to prevent exploitation of CVE HTTP/2 Rapid Reset

@openshift-ci openshift-ci bot requested review from beekhof and slintes October 24, 2023 09:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7
Copy link
Member Author

razo7 commented Oct 24, 2023

/retest

1 similar comment
@razo7
Copy link
Member Author

razo7 commented Oct 24, 2023

/retest

args:
- "--secure-listen-address=0.0.0.0:8443"
- --http2-disable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align with other args and add quotes.
Also the PR title is confusing, sounds like updating a var?

- update kube-rbac-proxy to v0.15.0
- disable HTTP/2 to prevent exploitation of CVE HTTP2 Rapid Reset
@razo7 razo7 force-pushed the rbac-proxy-update-nmo branch from b00ec3d to b77420e Compare October 24, 2023 13:39
@razo7 razo7 changed the title Update RBAC_PROXY_OCP_VERSION to 0.15.0 Upgrade kube-rbac-proxy image to v0.15.0 and disable HTTP/2 Oct 24, 2023
@slintes
Copy link
Member

slintes commented Oct 24, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 24, 2023
@clobrano
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot merged commit c5459af into medik8s:main Oct 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants