Fix orphaned CR handling #360
Conversation
Signed-off-by: Marc Sluiter <[email protected]>
No remediator is deleting AND recreating nodes anymore, so it's safe to delete the CR when its node was deleted. For backwards compapibilty we keep the old behaviour for remediators which mark their CR with the PermanentNodeDeletionExpected condition: the CR will only be deleted once it succeeded. Fixes the case when escalating remediation with MDR was used, and CRs for other remediators weren't cleaned up after node deletion. Signed-off-by: Marc Sluiter <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
|
flaky MHC test, not relevant /override ci/prow/4.14-openshift-e2e |
|
@slintes: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@slintes: Overrode contexts on behalf of slintes: ci/prow/4.14-openshift-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@slintes: new pull request created: #361 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why we need this PR
CRs for deleted nodes weren't cleaned up
Changes made
No remediator is deleting AND recreating nodes anymore, so it's safe
to delete the CR when its node was deleted.
For backwards compapibilty we keep the old behaviour for remediators
which mark their CR with the PermanentNodeDeletionExpected condition:
the CR will only be deleted once it succeeded.
Which issue(s) this PR fixes
Fixes #356
ECOPROJECT-2489
Test plan
Unit test updated