Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check control plane topology #353

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

slintes
Copy link
Member

@slintes slintes commented Dec 5, 2024

Why we need this PR

There might be clusters which handle fencing on their own in future.
Disallow NHC configs in these cases, in order to prevent fencing conflicts.

Changes made

  • Added control plane topology check to cluster capabilities
  • Use capabilities in admission webhook

Which issue(s) this PR fixes

ECOPROJECT-2395

Test plan

  • added unit test for admission webhook
  • existing e2e tests ensure we don't add regression

Signed-off-by: Marc Sluiter <[email protected]>
@openshift-ci openshift-ci bot requested review from beekhof and razo7 December 5, 2024 16:27
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 5, 2024
@slintes
Copy link
Member Author

slintes commented Dec 5, 2024

/test 4.17-openshift-e2e

@mshitrit
Copy link
Member

mshitrit commented Dec 5, 2024

/lgtm

Signed-off-by: Marc Sluiter <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Dec 5, 2024
@slintes
Copy link
Member Author

slintes commented Dec 5, 2024

/test 4.17-openshift-e2e

@slintes
Copy link
Member Author

slintes commented Dec 6, 2024

works now after fixing RBAC:

  • green on k8s
  • green for HA topology: 2024-12-05T20:08:03.894296519Z INFO setup supported control plane topology {"topology": "HighlyAvailable"}

@slintes slintes marked this pull request as ready for review December 6, 2024 08:24
@openshift-ci openshift-ci bot requested review from clobrano and mshitrit December 6, 2024 08:24
@clobrano
Copy link
Contributor

clobrano commented Dec 6, 2024

/lgtm

@slintes
Copy link
Member Author

slintes commented Dec 6, 2024

/retest

2 similar comments
@slintes
Copy link
Member Author

slintes commented Dec 6, 2024

/retest

@slintes
Copy link
Member Author

slintes commented Dec 6, 2024

/retest

@slintes
Copy link
Member Author

slintes commented Dec 6, 2024

all kind of different errors on 4.18, let's keep an eye on it in #352 ...

/override ci/prow/4.18-openshift-e2e

Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.18-openshift-e2e

In response to this:

all kind of different errors on 4.18, let's keep an eye on it in #352 ...

/override ci/prow/4.18-openshift-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 6efed12 into medik8s:main Dec 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants