Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes #330

Merged
merged 2 commits into from
Jul 1, 2024
Merged

minor fixes #330

merged 2 commits into from
Jul 1, 2024

Conversation

slintes
Copy link
Member

@slintes slintes commented May 23, 2024

Why we need this PR

testing tide with little fixes

Changes made

  • better phrasing for frozen kernels
  • fixed code comment

@openshift-ci openshift-ci bot requested review from beekhof and razo7 May 23, 2024 16:34
Signed-off-by: Marc Sluiter <[email protected]>
@slintes slintes changed the title better phrasing for frozen kernels minor fixes May 23, 2024
@clobrano
Copy link
Contributor

/lgtm

@slintes
Copy link
Member Author

slintes commented May 23, 2024

/retest

@slintes slintes removed the approved label Jun 11, 2024
@slintes
Copy link
Member Author

slintes commented Jun 11, 2024

/approve

@slintes
Copy link
Member Author

slintes commented Jun 11, 2024

/retest

@slintes
Copy link
Member Author

slintes commented Jun 29, 2024

/approve cancel

@openshift-ci openshift-ci bot removed the approved label Jun 29, 2024
@slintes
Copy link
Member Author

slintes commented Jun 29, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Jun 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slintes
Copy link
Member Author

slintes commented Jun 29, 2024

/test 4.12-test

@slintes
Copy link
Member Author

slintes commented Jun 29, 2024

/retest

2 similar comments
@slintes
Copy link
Member Author

slintes commented Jun 29, 2024

/retest

@slintes
Copy link
Member Author

slintes commented Jun 30, 2024

/retest

@slintes
Copy link
Member Author

slintes commented Jun 30, 2024

/test 4.15-openshift-e2e

Copy link
Contributor

openshift-ci bot commented Jun 30, 2024

@slintes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.16-openshift-e2e 036a3d9 link false /test 4.16-openshift-e2e
ci/prow/4.15-openshift-e2e 036a3d9 link false /test 4.15-openshift-e2e
ci/prow/4.17-openshift-e2e 036a3d9 link false /test 4.17-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8c610ae into medik8s:main Jul 1, 2024
24 of 27 checks passed
@slintes
Copy link
Member Author

slintes commented Aug 7, 2024

/cherry-pick release-0.8

@openshift-cherrypick-robot

@slintes: new pull request created: #340

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants