-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build a file-based catalog #311
base: main
Are you sure you want to change the base?
Conversation
Replace the deprecated db-based catalog with a file-based one. Signed-off-by: Carlo Lobrano <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
interesting, it seems kind isn't happy with this change
|
I am testing the k8s-e2e phase, do not merge |
8d995a9
to
1b89629
Compare
Signed-off-by: Carlo Lobrano <[email protected]>
@clobrano: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Why we need this PR
Currently NHC's Makefile creates a db-based catalog, which is deprecated
Changes made
This change creates a file-based catalog
https://docs.openshift.com/container-platform/4.14/operators/admin/olm-managing-custom-catalogs.html#olm-managing-custom-catalogs-fb
Which issue(s) this PR fixes
https://issues.redhat.com/browse/ECOPROJECT-1948
Test plan