Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Go install in Dockerfile #133

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix Go install in Dockerfile #133

merged 1 commit into from
Mar 15, 2024

Conversation

clobrano
Copy link
Contributor

Why we need this PR

Currently, installing the latest z version of golang from the go
toolchain available in the repository (via go get) is failing with the
following error:

go: updating go.mod requires go >= 1.21.8 (running go 1.21.7; GOTOOLCHAIN=local)

Changes made

This change installs directly the wanted version from
https://golang.org/dl without using the distribution repository.

@clobrano
Fix Go install in Dockerfile
07aba94 
Currently, installing the latest z version of golang from the go
toolchain available in the repository (via go get) is failing with the
following error:

go: updating go.mod requires go >= 1.21.8 (running go 1.21.7; GOTOOLCHAIN=local)

To fix it, this change installs directly the wanted version from
https://golang.org/dl without using the distribution repository.

Signed-off-by: Carlo Lobrano <[email protected]>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@clobrano
Copy link
Contributor Author

/test 4.15-openshift-e2e

@openshift-ci openshift-ci bot added the lgtm label Mar 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clobrano clobrano marked this pull request as ready for review March 15, 2024 12:41
@openshift-ci openshift-ci bot requested review from mshitrit and razo7 March 15, 2024 12:41
@openshift-merge-bot openshift-merge-bot bot merged commit 8d23e21 into medik8s:main Mar 15, 2024
19 checks passed
@mshitrit mshitrit mentioned this pull request Mar 17, 2024
Merged
@clobrano clobrano deleted the dockerfile-golang-install-0 branch August 8, 2024 09:47
@clobrano
Copy link
Contributor Author

clobrano commented Aug 8, 2024

/cherry-pick release-0.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 8, 2024
Merged
@openshift-cherrypick-robot
Copy link

@clobrano: new pull request created: #140

In response to this:

/cherry-pick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slintes slintes slintes approved these changes

@mshitrit mshitrit Awaiting requested review from mshitrit

@razo7 razo7 Awaiting requested review from razo7

Assignees

@slintes slintes

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clobrano @openshift-cherrypick-robot @slintes