-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor getMachine to clarify machine-not-found error conditions #113
Refactor getMachine to clarify machine-not-found error conditions #113
Conversation
Clarified the conditions under which an error would be returned or not when the Machine was not found in the cluster. Signed-off-by: Carlo Lobrano <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Regarding this comment
I think that we can consider a Machine "unhandled" even before checking |
/test 4.14-openshift-e2e |
/lgtm giving others the chance to review as well |
/unhold |
/retest |
1 similar comment
/retest |
Clarified the conditions under which an error would be returned or not
when the Machine was not found in the cluster.