Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-realtime-settings #1344

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

EzraEllette
Copy link
Contributor

@EzraEllette EzraEllette commented Feb 12, 2025

description

  • user enable real time audio with deepgram and does not set deepgram api key (CLI throw loads of errors)
    • will only throw the error once by checking for the variables
  • user enable real time audio with screenpipe cloud and they don't have access to screenpipe cloud or something like this (did not subscribe)
    • Will return authorization error and keep throwing it in a loop
  • user try to use real time audio in CLI mode with deepgram without api key
    • will only throw the error once by checking for the variables
  • user try to use real time audio in CLI mode with screenpipe cloud and does not properly configure the env var required (check related issues / PR / codebase to figure out)
    • Will continue to throw errors.

related issue: #1335

how to test

  1. run screenpipe with realtime enabled and no keys
  2. run screenpipe with a deployed ai-proxy and test auth

Validating the custom url and key seems out of scope. I don't have screenpipe cloud so I can't test the authorization

/claim #1335

…logic

- Add validation to skip realtime recording if no Deepgram API key is provided
- Remove unused import in server core module
- Fix indentation in server recording logic
- Update core and realtime modules to handle Deepgram API key and URL configuration
- Allow realtime transcription with custom WebSocket URL when API key is not provided
- Remove redundant API key validation in realtime streaming
Copy link

vercel bot commented Feb 12, 2025

@EzraEllette is attempting to deploy a commit to the louis030195's projects Team on Vercel.

A member of the Team first needs to authorize it.

@louis030195
Copy link
Collaborator

i think this is good but missing some UI changes on app settings, it's not intuitive atm

@EzraEllette
Copy link
Contributor Author

@louis030195 What is not intuitive? The process is select screenpipe cloud as the realtime transcription engine and restart screenpipe. Maybe disable the selection unless either screenpipe-cloud is subscribed or a custom deepgram key is provided?

@louis030195
Copy link
Collaborator

so last time there was a user running real time transcription and he did not set api key or using screenpipe cloud without having a subscription or something like this and not until we looked into the logs we saw something was wrong

it should show in the UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants