forked from sraoss/pg_ivm
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to create unlogged IMMVs #1
Open
Jamal-B
wants to merge
3
commits into
main
Choose a base branch
from
allow-to-create-unlogged-immv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
-- functions | ||
|
||
CREATE FUNCTION create_immv(text, text, boolean default false) | ||
RETURNS bigint | ||
STRICT | ||
AS 'MODULE_PATHNAME', 'create_immv' | ||
LANGUAGE C; | ||
|
||
DROP FUNCTION create_immv(text, text); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
# incremental view maintenance extension_ | ||
comment = 'incremental view maintenance on PostgreSQL' | ||
default_version = '1.9' | ||
default_version = '1.10' | ||
module_pathname = '$libdir/pg_ivm' | ||
relocatable = false | ||
schema = pg_catalog |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ | |
|
||
Summary: PostgreSQL-based distributed RDBMS | ||
Name: %{sname}_%{pgmajorversion} | ||
Version: 1.9 | ||
Version: 1.10 | ||
Release: 1%{dist} | ||
License: BSD | ||
Vendor: IVM Development Group | ||
|
@@ -55,6 +55,8 @@ PATH=%{pginstdir}/bin:$PATH %{__make} %{?_smp_mflags} INSTALL_PREFIX=%{buildroot | |
%endif | ||
|
||
%changelog | ||
* Mon Aug 26 2024 - Jamal Boukaffal <[email protected]> 1.10-1 | ||
- Update to 1.10 | ||
* Fri Jul 31 2024 - Yugo Nagata <[email protected]> 1.9-1 | ||
- Update to 1.9 | ||
* Fri Mar 1 2024 - Yugo Nagata <[email protected]> 1.8-1 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In such situation > In such a situation
we can use
refresh_immv
> we can use therefresh_immv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci pour la remarque mais je préfère laisser tel quel car ce ne sont pas des erreurs importantes/gênantes/structurantes et qu'elles ne proviennent pas de mes commits. Dans le 1er commit j'ai bien corrigé des typos qui étaient déjà dans le projet, mais uniquement car elles concernaient des noms de fonctions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dit autrement, je ne voudrais pas trop distraire le(s) mainteneur(s) avec autre chose que le but principal de cette PR, dont je ne suis pas du tout sûr qu'elle soit acceptée 🙂