-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migration from SurfaceTextureEntry to SurfaceProducer #824
base: main
Are you sure you want to change the base?
chore: migration from SurfaceTextureEntry to SurfaceProducer #824
Conversation
i did try https://developer.android.com/reference/android/view/SurfaceHolder either that i am doing it wrong due to not understanding the code fully, or it doesnt work for our case anyway, leaving this here for tracking https://github.com/abdelaziz-mahdy/media_kit/tree/migration-to-impller-test |
also i tested with both branches have the same problem, the first video rendering will be incorrect, and then the next video will be correct,note the
example of rendering problems yes i am testing on emulator but on main none of these problems happen so there is a problem in the migration i did, @alexmercerind looks like i failed to do it and will need your help in this one also let me know which branch is more clear to be merged with this one. |
cant figure out how to fix those the first video render as a flicker of colors black screen instead of rendering, it doesnt happen all the time, so i cant figure when and why it happens video scale is wrong(this is gone, or much less) so lets ignore it for now (only for the first video from the sample it happens) |
this issue is a fix for #707 , since flutter migrated to SurfaceProducer for impeller https://docs.flutter.dev/release/breaking-changes/android-surface-plugins
right now this is blocked by setOnFrameAvailableListener , since i cant find it in the new class and cant find any mention of it anywhere