fix: Seek indicators get stuck as mounted but invisible #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usual double-tap-to-seek code flow is: 1. The user double-taps the screen, which sets `_mountSeek[...]Button` to `true` (mounting the indicator and starting its animation) and starts a submission timer. 2. The animation to display the seek indicator ends. 3. The timer calls `onSubmitted`, which sets `_hideSeek[...]Button` to `true`. 4. Next time `build()` runs, `_hideSeek[...]Button` causes the animation to be restarted, now going backwards and hiding the indicator. 5. The animation ends, sees `_hide[...]Button` is `true`, and sets it and `_mountSeek[...]Button` to `false`, completely unmounting the indicator. However, if between steps 3 and 5, the user double-taps again, a new timer will be started. If that timer then invokes `onSubmitted` *after* step 5, `_hide[...]Button` will be set to `true` while `_mountSeek[...]Button` is `false`. This means that, next time the user double-taps the screen, the animation will be run with a start *and* end point of `0.0`, resulting in `onEnd` never being called to unmount the indicator. Thus, the indicator stays mounted and still responds to touch events, but it's now completely invisible. In order to fix this, if a double-tap occurs while hiding the indicator, we can just set `_hideSeek[...]Button` back to `false`, essentially re- starting the entire flow. This allows the user to safely interact with the indicator during the entire period that it's visible on-screen.
|
i have fixed that in a previous pr but leave this open since it looks cleaner, but further testing will show which one is more stable |
|
since #640 is merged i guess this should be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usual double-tap-to-seek code flow is:
_mountSeek[...]Buttontotrue(mounting the indicator and starting its animation) and starts a submission timer.onSubmitted, which sets_hideSeek[...]Buttontotrue.build()runs,_hideSeek[...]Buttoncauses the animation to be restarted, now going backwards and hiding the indicator._hide[...]Buttonistrue, and sets it and_mountSeek[...]Buttontofalse, completely unmounting the indicator.However, if between steps 3 and 5, the user double-taps again, a new timer will be started. If that timer then invokes
onSubmittedafter step 5,_hide[...]Buttonwill be set totruewhile_mountSeek[...]Buttonisfalse. This means that, next time the user double-taps the screen, the animation will be run with a start and end point of0.0, resulting inonEndnever being called to unmount the indicator. Thus, the indicator stays mounted and still responds to touch events, but it's now completely invisible.In order to fix this, if a double-tap occurs while hiding the indicator, we can just set
_hideSeek[...]Buttonback tofalse, essentially re- starting the entire flow. This allows the user to safely interact with the indicator during the entire period that it's visible on-screen.