Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve Shopping List UI #4608

Draft
wants to merge 6 commits into
base: mealie-next
Choose a base branch
from
Draft

feat: Improve Shopping List UI #4608

wants to merge 6 commits into from

Conversation

miah120
Copy link

@miah120 miah120 commented Nov 25, 2024

What type of PR is this?

  • feature

What this PR does / why we need it:

  • Focus is moved to the notes input when adding or editing an item in the shopping list
  • Edit/add item card actions (e.g., cancel, save, toggle food, etc) moved to inside card
  • Remove delete button from add item workflow (its identical to cancel, so it just clutters UI)
  • Move "delete checked items" button to the checked items section
  • Tweaks to padding to improve logical grouping
  • Remove nesting from the three dot menu

Before/After:
image
image

image
image

image
image

Which issue(s) this PR fixes:

None

Testing

Tested in docker container

@Kuchenpirat
Copy link
Collaborator

Depends on #4415

@Kuchenpirat Kuchenpirat self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kuchenpirat Kuchenpirat

Labels
do not merge feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miah120 @Kuchenpirat @Wetzel402