feat: Support additional compression algorithms #4282
Closed
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR introduces support for newer compression algorithms (Brotli and Zstd) in addition to the currently supported Gzip. By dynamically selecting the best compression algorithm based on the Accept-Encodings header from the request, this change aims to improve overall performance, particularly in low bandwidth scenarios
Which issue(s) this PR fixes:
Not really any issue per se, it just improves performance a little.
Special notes for your reviewer:
I've done a quick scan over the
starlette-compress
library used here, as it is still pretty new and very small. I haven't found any issues with it. It literally just chooses the best compression and compresses the content using standard libraries. Feel free to have another look around, in case I missed anything :-)Testing
I've been using this change in my private mealie instance for the last week without any issues.