Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g11n: upgrade to latest workshopper infra and lib versions to bootstrap L10n #17

Merged
merged 6 commits into from
Feb 20, 2015

Conversation

tdd
Copy link
Contributor

@tdd tdd commented Feb 19, 2015

Hey Martin!

First, gratz on lololodash, it's a cool workshop.

As part of the nodeschool/organizers#64 g11n effort currently underway, I'm bringing all workshopper-based workshops up to snuff on the latest versions of it so they can get translated (L10n) readily.

I'm also bringing them on the latest versions of their tested libs, and re-testing all the exercises, to reduce the risk of obsolescence.

As your workshop was on a very recent version of workshopper, it needed very little changes on the i18n side. This is a short PR for that aspect.

Expect another PR within 24 hours with the FR L10n. I hope you see this favorably. We're hosting the first Paris NodeSchool session this Saturday, and it would be fantastic if this could all be merged in and bumped in npm by then 😄

I am, of course, available for all questions and discussions on this.

Best,

@tdd
Copy link
Contributor Author

tdd commented Feb 19, 2015

By the way, I see you repeat the same templating info at the end of every exercise. This sounds like a great candidate for using workshopper-boilerplate instead. Rod is at work on an upgrade of it right now, to reduce the risk of duplicate files on multiple prints of a single exercise, but once that's fixed, it could be cool to leverage it for better UX. I'll ping you then.

@tdd tdd mentioned this pull request Feb 19, 2015
@mdunisch
Copy link
Owner

Hi @tdd,

thank you for that huuuuge commit 👍
I'll take a closer look at this tomorrow!

@tdd
Copy link
Contributor Author

tdd commented Feb 19, 2015

Hey Martin!

Sure thing! Please do consider this one and the next one, #18, which adds the FR L10n on top of this.

I'm not super happy with how I had to go about g11n for your custom exercise/verification code, Rod and I def need to augment workshopper so it handles "code objects comparison" (with jsdiffs, too), not just stdout, thereby helping lololodash reduce its custom aspects and get easier to localize.

If you can indeed look at this, and ideally like it, merge it, and npm bump before Saturday, that would be super awesome 🎉 😄

@mdunisch mdunisch merged commit b154945 into mdunisch:master Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants