Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intl.DateTimeFormat.resolvedOptions dateStyle, timeStyle #33634

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

medmunds
Copy link

Description

Document dateStyle and timeStyle for Intl.DateTimeFormat.resolvedOptions() return value.

Motivation

These properties were added in tc39/ecma402#457, but are not covered by the current documentation.

Additional details

See current https://tc39.es/ecma402/#table-datetimeformat-resolvedoptions-properties

Related issues and pull requests

@medmunds medmunds requested a review from a team as a code owner May 16, 2024 01:53
@medmunds medmunds requested review from Josh-Cena and removed request for a team May 16, 2024 01:53
@github-actions github-actions bot added Content:JS JavaScript docs size/xs 0-5 LoC changed labels May 16, 2024
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm in the process of updating these docs but it's good to make them more correct. I just have one question.

Copy link
Contributor

@github-actions github-actions bot added size/s 6-50 LoC changed and removed size/xs 0-5 LoC changed labels Jun 5, 2024
medmunds and others added 4 commits June 5, 2024 13:56
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- Clarify dateStyle and timeStyle
- Add example
- Add missing hourCycle
- Clarify calendar and numberingSystem
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs size/s 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants