Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @media/resolution index.md #33596

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

scheinercc
Copy link
Contributor

Description

Add examples for additional resolution unit, dppx, x and dpcm, similar to #31902

Motivation

In #30393 we ended up changing https://developer.mozilla.org/en-US/docs/Web/CSS/resolution#syntax, but the original request was for https://developer.mozilla.org/en-US/docs/Web/CSS/@media/resolution, which this pull request now includes.

Additional details

Related issues and pull requests

Add examples for additional resolution unit, dppx, x and dpcm, similar to mdn#31902
@scheinercc scheinercc requested a review from a team as a code owner May 13, 2024 23:58
@scheinercc scheinercc requested review from dipikabh and removed request for a team May 13, 2024 23:58
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s 6-50 LoC changed labels May 13, 2024
Copy link
Contributor

github-actions bot commented May 14, 2024

Preview URLs

(comment last updated: 2024-06-05 01:37:32)

@estelle
Copy link
Member

estelle commented Jun 4, 2024

Instead of adding new values on there own, let's change two of the three existing dpi values to different resolution units.

Removed new values and changed two of the three existing dpi values to different resolution units instead.
@scheinercc
Copy link
Contributor Author

@estelle I pushed a new commit. The wording might need to be rephrased :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants