Skip to content

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Sep 2, 2025

See https://w3c.github.io/webappsec-credential-management/#federated, the FederatedCredential interface has no members "iconURL" or "name": The constructor has these as parameters but their support seems to be identical to the constructor (and other constructor parameters also exist), so I think we should remove this here as not needed.

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed labels Sep 2, 2025
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these meant to record support for the options of the FederatedCredential constructor?

https://developer.mozilla.org/en-US/docs/Web/API/FederatedCredential#examples mentions these, whereas https://developer.mozilla.org/en-US/docs/Web/API/FederatedCredential/FederatedCredential#parameters doesn't.

@Elchi3
Copy link
Member Author

Elchi3 commented Sep 3, 2025

Were these meant to record support for the options of the FederatedCredential constructor?

Yes, and as I said above:

The constructor has these as parameters but their support seems to be identical to the constructor (and other constructor parameters also exist), so I think we should remove this here as not needed.

https://developer.mozilla.org/en-US/docs/Web/API/FederatedCredential#examples mentions these, whereas https://developer.mozilla.org/en-US/docs/Web/API/FederatedCredential/FederatedCredential#parameters doesn't.

The MDN constructor page seems outdated to me, it should mention options.

@caugner
Copy link
Contributor

caugner commented Sep 3, 2025

their support seems to be identical to the constructor (and other constructor parameters also exist), so I think we should remove this here as not needed

I think we should cover constructor options, even those that were supported from the beginning. This makes it explicit that developers can use theses, and allows MDN to add inline support statuses in the future.

My understanding is that the "don't add subfeature if support is equal to parent" only applies to behavioral subfeatures?!

Edit: In other words, instead of removing, I would opt for moving these features below the constructor feature.

@Elchi3
Copy link
Member Author

Elchi3 commented Sep 3, 2025

I think that would require to add all constructor options then, otherwise just adding these two sort of implies that the others aren't supported.

@caugner
Copy link
Contributor

caugner commented Sep 5, 2025

I think that would require to add all constructor options then, otherwise just adding these two sort of implies that the others aren't supported.

I think there are other examples where BCD is not complete, but here I would still suggest to move those two subfeatures, and file an issue about this missing options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants