-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Remove iconURL and name from FederatedCredential #27733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these meant to record support for the options of the FederatedCredential
constructor?
https://developer.mozilla.org/en-US/docs/Web/API/FederatedCredential#examples mentions these, whereas https://developer.mozilla.org/en-US/docs/Web/API/FederatedCredential/FederatedCredential#parameters doesn't.
Yes, and as I said above:
The MDN constructor page seems outdated to me, it should mention options. |
I think we should cover constructor options, even those that were supported from the beginning. This makes it explicit that developers can use theses, and allows MDN to add inline support statuses in the future. My understanding is that the "don't add subfeature if support is equal to parent" only applies to behavioral subfeatures?! Edit: In other words, instead of removing, I would opt for moving these features below the constructor feature. |
I think that would require to add all constructor options then, otherwise just adding these two sort of implies that the others aren't supported. |
I think there are other examples where BCD is not complete, but here I would still suggest to move those two subfeatures, and file an issue about this missing options. |
See https://w3c.github.io/webappsec-credential-management/#federated, the FederatedCredential interface has no members "iconURL" or "name": The constructor has these as parameters but their support seems to be identical to the constructor (and other constructor parameters also exist), so I think we should remove this here as not needed.