-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Re-add IDBDatabase abort event #27167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Based on #15006.
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the PR that's going to appear in the commit history, can you add some text to the PR description summarizing that we're doing something exceptional here, why, and that we're not planning to extend this to other PRs? I'd like some kind of paper trail that doesn't require reading the entirety of at least one issue (and probably more).
@ddbeck Can you elaborate the "something exceptional" bit? I have added a Motivation section in the PR now:
(Edit) I have now also added the following notecard: Important While the same may apply to 50+ events that can bubble to Element, Document, and Window, we do not intend to add corresponding data to those three interfaces. |
Based on #15006.
Summary
Adds the
abort
event onIDBDatabase
.Motivation
The IDBDatabase abort event is defined in the spec, and implemented in Chrome, Firefox, and Safari, so the data shouldn't
have been removed in the first place.
Important
While the same may apply to 50+ events that can bubble to Element, Document, and Window, we do not intend to add corresponding data to those three interfaces.
Test results and supporting details
The data was originally removed in #15006.
Related issues
Fixes: #15345