Fix Firefox compat for api.WebTransport options.serverCertificateHashes #23058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
zvolin
force-pushed
the
firefox-certhashes
branch
from
42fc538
to
ce5a5c7
Compare
zvolin
force-pushed
the
firefox-certhashes
branch
from
ce5a5c7
to
86272d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates firefox support for
api.WebTransportoptions.serverCertificateHashessince version 125.0.1Test results and supporting details
We're developing a p2p node which runs in wasm and uses webtransport to communicate. We were mostly targeting chrome browsers so far because we need serverCertificateHashes to connect with a huge majority of peers, but we ran it on firefox when debugging some other thing and to our surprise it worked.
It seems an oversight from Mozilla side that they didn't include this information in their release notes, but this bug got fixed here.
The PR's milestone is 123.0a1 however I've checked with the 124.0.1 and it doesn't support this feature yet, so it must've been added in 125.0.1.
Related issues
Fixes #23057