This repository was archived by the owner on Aug 23, 2024. It is now read-only.
Check to see if behavior is already attached to element #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a check to see if the behavior is already attached to the element. This allows you to use the fetch service multiple times on the same source elements.
Consider the following scenario.
In the code above, related Asset elements are fetched and attached to the source elements. Then the source elements with the attached
fetched_elements
are passed to the fetch service to retrieve related categories. However, a newfetched_elements
behavior will be attached again, losing the previously fetched images. This results in$elements[0]->fetch('images')
returning null instead of the expected AssetFileModels collection.