Create backup of the download cache before deleting it #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional 'backup' argument to clear_download_cache). Also includes fixes to correctly determine the urlmap filename on Python 3, and to catch the correct exception from the dbm module on Python 3 (a 'dbm.error' exception is raised, not an ImportError)
| cache_backups = clear_download_cache(backup=True) | ||
| warn(msg + ' A new cache will be created, but a backup of ' | ||
| 'the old cache was saved to {0} and {1}.'.format( | ||
| *cache_backups), AstropyWarning) |
There was a problem hiding this comment.
In addition to making a new db file named from the db library in use, I think this can be simplified a bit to not actually make a backup of all the cached files. They can just stay right where they are. If the cleared cache DB is used then some already existing files will still be re-downloaded unnecessarily, but then once we get their hash we can just check if the file already exists and leave it there. I think there's probably no harm in that. The worse that can happen is that that there are saved files that are not in the DB. We could later add a cleanup method for that if it really comes to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(adds a new optional 'backup' argument to clear_download_cache). Also includes fixes to correctly determine the urlmap filename on Python 3, and to catch the correct exception from the dbm module on Python 3 (a 'dbm.error' exception is raised, not an ImportError)