Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Remove component to data mapping from data manager #451
[Tidy] Remove component to data mapping from data manager #451
Changes from 21 commits
304f058
4161a09
b5cd1ae
f4a748b
ca1624d
7662b56
92e6c68
9442b2b
ec988d7
8185617
a980cec
8aa743d
e864356
96fc5ce
a9d26c6
f7f07cc
d4fbd26
3b341fd
365b5aa
2ba74cb
bb9b9fa
1d65558
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit of code probably won't last very long. After #439 is merged then I don't think any code does
__call__
without specifying adata_frame
. Removing or at least rewriting this bit of code will then fix the problem @petar-qb pointed out in #398 (comment).