-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Fix merge errors / start vale checking in docs #422
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ey/vizro into docs/fix-merge-vale-added
I've just pushed a change 👍 From some of the threads I've quickly read e.g. this one, it seems like To test it, I just added "werkzeug" in the vizro-core or vizro-ai The docs build is currently still failing because of some broken links - not sure if these are false positives? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @stichbury - LGTM in general! Thanks for tidying 🧹
I've noticed a couple other merge conflicts which I pointed out. Some of the rephrases sound a bit odd to me now, but it might just be because I am not a native speaker 😄 Especially the replacements from "provide" to "pass" sound a bit off, because it now says "pass with ..." and "pass to" sounds more correct to me? Anyways, I've commented on the relevant sections. So if relevant please take a look, if not, then feel free to ignore :)
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Co-authored-by: Li Nguyen <[email protected]> Signed-off-by: Jo Stichbury <[email protected]>
Co-authored-by: Li Nguyen <[email protected]> Signed-off-by: Jo Stichbury <[email protected]>
Co-authored-by: Li Nguyen <[email protected]> Signed-off-by: Jo Stichbury <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Jo Stichbury <[email protected]>
Co-authored-by: Li Nguyen <[email protected]> Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Co-authored-by: Li Nguyen <[email protected]> Signed-off-by: Jo Stichbury <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Just have some minor comments, but from my side it's good to go 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a quick scan through - looks generally good 💪
Main question: is there a guidance when we must turn vale
off?
Some things I noticed:
- e.g. into for example -> is this not too long?
After searching the
Also in
I don't know if we should strictly get rid of them. However, here's a little warning in case it helps 😄. |
Signed-off-by: Jo Stichbury <[email protected]>
Co-authored-by: Li Nguyen <[email protected]> Signed-off-by: Jo Stichbury <[email protected]>
Good question! In some cases, I removed the "e.g." and didn't replace with "for example" because it does make it wordy, but in others, it is useful to spell out that it's just one of many options/examples. We are familiar with |
I don't need Vale with @petar-qb doing the checking :) Thanks for the spot! Some may be excluded because I've turned Vale off on docs with official type text like the safeguarding page. I'll look into why others haven't been flagged and fix them all for consistency. Thanks @petar-qb ! |
Description
Now ready for review. Sorry it's so large, it's because I have touched most of the docs pages at a superficial level to remove a few common issues that Vale is set to eliminate:
This PR also turns Vale on to run across all markdown in the
/docs
folders (thanks to @huong-li-nguyen).Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":