Added support for unassigning JIRA issues #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for unassigning JIRA issues. I settled on using the word "Unassigned", which matches what users see when observing issues in JIRA through its UI. The REST API will perform an unassignment when assignee=null. I chose a magic value approach for now for least disruption to existing dependencies.
An alternative magic value could be the string "null", but this feels more like an implementation detail, a quirk of the REST interface. Another alternative would be an explicit --unassign option/command. There is some precedence for this with the --delete command. Possibly, we could clean up the entire jiraclient interface with a subcommand-plus-options approach, similar to what git uses, which would be helpful for separating the notions of search from modification. I have avoided the bigger architecture issues with the choice of simple magic value.