Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Convert Times back to strings to handle when times are greater than midnight #490

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

huangh
Copy link
Contributor

@huangh huangh commented Mar 24, 2025

asana_ticket

Times are in String HH:MM:SS format, from glides https://mbta.github.io/schemas/events/glides/com.mbta.ctd.glides.trips_updated.v1#time

This is not valid when converted to hyper times. Those have a valid range of 00:00:00 - 24:00:00
https://tableau.github.io/hyper-db/docs/sql/datatype/datetime

Returning back to strings to match existing handling.

@huangh huangh requested a review from rymarczy March 24, 2025 17:20
@huangh huangh force-pushed the hh_glides_to_tableau3 branch from e7dd2ee to af71d02 Compare March 24, 2025 17:26
rymarczy
rymarczy previously approved these changes Mar 24, 2025
Copy link
Collaborator

@rymarczy rymarczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

Copy link

LCOV of commit 11c6269 during Continuous Integration (Python) #969

Summary coverage rate:
  lines......: 70.1% (2732 of 3900 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/tableau/jobs/glides.py                                                 |39.7%     73|    -     0|    -      0

@rymarczy rymarczy self-requested a review March 24, 2025 17:39
@huangh huangh merged commit 50097c5 into main Mar 24, 2025
5 checks passed
@huangh huangh deleted the hh_glides_to_tableau3 branch March 24, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants