chore: Pin asdf to 0.15.0 to avoid notice about 0.16 Go rewrite #1195
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudiejd
reviewed
Apr 2, 2025
| @@ -23,6 +23,8 @@ jobs: | |||
| # only run `asdf install` if we didn't hit the cache | |||
| - uses: asdf-vm/actions/install@v1 | |||
| if: steps.asdf-cache.outputs.cache-hit != 'true' | |||
| with: | |||
| asdf_branch: v0.15.0 | |||
|
|
|||
| build: | |||
| name: Build Elixir | |||
There was a problem hiding this comment.
I think you would also have to pin asdf for this job
|
is it worth just following the migration guide here so we can run the latest and greatest |
Because this is a 3rd party action, we don't have control of the default version used. There is apparently a recent fix that has been merged, but there doesn't seem to be a release that contains the change. We could use the commit hash instead of the major version (we're a couple behind anyway). Then we wouldn't need to pin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: ad hoc
(analogue to this ticket for gtfs_creator)
This prevents asdf from printing notices about the v0.16 Go rewrite every time it runs (i.e., between every single shell command issued during CI)
Reviewer Checklist