Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shuttle page save button and add cancel button #1176

Merged
merged 3 commits into from
Mar 31, 2025

Conversation

lemald
Copy link
Member

@lemald lemald commented Mar 28, 2025

Summary of changes

Asana Ticket: 🏹🐛 [extra] Fix save + cancel button in new shuttle definition page

I borrowed the layout / styling from the Disruptions page so it should match that.

I have an outstanding question about consistent casing in the Arrow UI, but in the meantime I'm leaving the buttons Title Case which seems at least largely consistent within the shuttle page itself.

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

@lemald lemald requested review from a team and dks-mbta and removed request for a team March 28, 2025 16:02
@lemald lemald force-pushed the lem-fix-shuttle-save-and-cancel branch from a3dbfb3 to 48350d2 Compare March 31, 2025 12:54
@lemald lemald merged commit 4894978 into master Mar 31, 2025
10 checks passed
@lemald lemald deleted the lem-fix-shuttle-save-and-cancel branch March 31, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants