Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix clear button on live-selects by clearing option on focus #1120

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meagharty
Copy link
Contributor

@meagharty meagharty commented Feb 10, 2025

Summary of changes

Asana Ticket: No ticket, need to confirm desired behavior

  • On focus, clear any dropdown results from previous searches
  • Fixes clear button behavior
    • Pressing 'x' will now clear the previous search terms

Previously: if a user typed "Ale" and chose a value, then click back into the input (triggering phx-focus), the options stay filtered by "Ale" until they start typing

Now: if a user types "Ale" and chooses a value, then clicks back into the input, there are no options until they start typing

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant