Temp eraser POC #154
Temp eraser POC #154
Conversation
| enum ToolNames { | ||
| BrushTool, | ||
| RectangleTool, | ||
| CircleTool, | ||
| LineTool, | ||
| EraserTool, | ||
| SelectionTool, | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't understand why this is needed. Can't you resuse the Types.Tool enum?
|
|
||
| # -------------------------------------------------------------------------------------------------- | ||
| func _on_eraser_pressed(): | ||
| _eraser_last_tool_active = _canvas._active_tool.get_class() |
There was a problem hiding this comment.
Instead of doing this, you should keep an internal Tool.Types variable in the InfiniteCanvas class and expose a get_active_tool_type() method. Then us this here .This way you can get rid of all the get_class() methods and the ToolNames enum
| # ------------------------------------------------------------------------------------------------- | ||
| func get_class(): return "BrushTool" |
There was a problem hiding this comment.
Get rid of this and all other get_class methods. See reasoning in other comment
| @@ -21,6 +21,9 @@ onready var _edit_palette_dialog: EditPaletteDialog = $EditPaletteDialog | |||
|
|
|||
| var _ui_visible := true | |||
| var _player_enabled := false | |||
| var _eraser_pressed_start: float | |||
| var _eraser_last_tool_active | |||
| var _eraser_swap_min_time: float = 400 | |||
|
Hey thanks for the feedback! Sorry for the delay, I just got back from a trip I left on right after I submitted this and it went a little longer than I thought it would. I'll go over my code tonight/tomorrow and try to implement your suggestions in and get it back to you. |
|
Don't worry, take your time :) |
Discussion issue: #152
Pull requested for initial commit of temporary eraser function, just wanted to add it for easier code comparison then having to go to my fork