fix: add custom parameters for the http-transport config #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
This Pull Request introduces enhancements and fixes to the HTTP transport configuration logic within the grpc-consul-resolver library. It primarily aims to offer more flexibility and control over the HTTP transport used for communication with Consul, enabling users to customize HTTP transport parameters such as idle connections, timeouts, and compression settings.
What:
target
struct to support customization of HTTP transport parameters likeMaxIdleConns
,IdleConnTimeout
,DisableCompression
,TLSHandshakeTimeout
, andExpectContinueTimeout
.TestCLient
toTestClient
to correct a typo.How can it be used:
How did you test it:
target_test.go
to cover the parsing and handling of the new HTTP transport parameters.Notes for the reviewer:
target
struct, ensuring they are correctly parsed and applied to the HTTP transport.TestClient
) is minor but improves code readability and consistency.