Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAK: Migrate to Svelte 5 #283

Merged
merged 2 commits into from
Oct 23, 2024
Merged

BREAK: Migrate to Svelte 5 #283

merged 2 commits into from
Oct 23, 2024

Conversation

mazipan
Copy link
Owner

@mazipan mazipan commented Oct 23, 2024

Closes

Description

Migrate to Svelte 5

Current Tasks

  • Running migration script npx sv migrate svelte-5
  • Install all new deps
  • Manual fix for failed migration
    • Temporary replace $$props.class to _$$props.class
    • Move to class to $props with renaming the props name, example: let { class: clazz }: Props = $props();
    • Fix PageData typings
  • Test run dev in local
  • Test run build in local

@mazipan mazipan force-pushed the break/migrate-svelte-5 branch from 43ace1e to 95c2cd8 Compare October 23, 2024 01:52
@mazipan mazipan removed the automerge label Oct 23, 2024
@mazipan mazipan merged commit 29bca19 into master Oct 23, 2024
2 checks passed
@mazipan mazipan deleted the break/migrate-svelte-5 branch October 23, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant