Skip to content

Commit 83ed700

Browse files
author
katarzyna.otylia.sikora@gmail.com
committed
fix typo in dnamapping
1 parent f7a3453 commit 83ed700

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

snakePipes/shared/rules/whatshap.snakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
def collect_bam():
22
bam = "filtered_bam/{sample}.filtered.bam"
3-
if pipeline == "dnamapping" and useSpikeinForNorm:
3+
if pipeline == "dnamapping" and useSpikeInForNorm:
44
bam = "split_bam/{sample}_host.bam"
55
return(bam)
66

snakePipes/workflows/DNAmapping/DNAmapping.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def parse_args(defaults={"verbose": False, "configFile": None,
2727
"UMIDedup": False, "UMIDedupOpts": "",
2828
"UMIDedupSep": "_", "UMIBarcode": False, "cutntag": False,
2929
"bcPattern": "NNNNCCCCCCCC", "aligner":"Bowtie2",
30-
"pvcf": None, "useSpikeinForNorm": False, "spikeinExt": None}):
30+
"pvcf": None, "useSpikeInForNorm": False, "spikeinExt": None}):
3131
"""
3232
Parse arguments from the command line.
3333
"""
@@ -119,14 +119,14 @@ def parse_args(defaults={"verbose": False, "configFile": None,
119119
help="Phased vcf required for whatshap haplotagging. (default: '%(default)s')",
120120
default=defaults["pvcf"])
121121

122-
optional.add_argument("--useSpikeinForNorm",
123-
dest="useSpikeinForNorm",
122+
optional.add_argument("--useSpikeInForNorm",
123+
dest="useSpikeInForNorm",
124124
action="store_true",
125125
help="Split bam files by host and spikein genome, then scale bam coverage results by spikein-derived size factors.")
126126

127127
optional.add_argument("--spikeinExt",
128128
dest="spikeinExt",
129-
help="Extention of spikein chromosome names in the hybrid genome. Ignored if splitHybridGenome is False (default: '%(default)s') .",
129+
help="Extention of spikein chromosome names in the hybrid genome. Ignored if useSpikeInForNorm is False (default: '%(default)s') .",
130130
default=defaults["spikeinExt"])
131131

132132
return parser

snakePipes/workflows/DNAmapping/Snakefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ include: os.path.join(maindir, "shared", "tools" , "deeptools_cmds.snakefile")
4646
# deepTools QC
4747
include: os.path.join(maindir, "shared", "rules", "deepTools_qc.snakefile")
4848

49-
if useSpikeinForNorm:
49+
if useSpikeInForNorm:
5050
include: os.path.join(maindir, "shared", "rules", "split_bam_ops_DNA_spikein.snakefile")
5151

5252
## MultiQC
@@ -116,7 +116,7 @@ def run_computeGCBias(GCBias):
116116
return(file_list)
117117

118118
def run_splitBam_ops():
119-
if useSpikeinForNorm:
119+
if useSpikeInForNorm:
120120
file_list = expand("split_bam/{sample}_{part}.bam",sample=samples,part=part)
121121
file_list.append(
122122
[expand("split_deepTools_qc/multiBamSummary/{part}.scaling_factors.txt",part=part),

snakePipes/workflows/DNAmapping/defaults.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,6 @@ verbose: false
6767
#phased vcf
6868
pvcf:
6969
#arguments related to hybrid genome alignment
70-
useSpikeinForNorm: False
70+
useSpikeInForNorm: False
7171
spikeinExt: "_spikein"
7272
spikein_bin_size: 1000

snakePipes/workflows/DNAmapping/internals.snakefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def get_host_and_spikein_chromosomes(genome_index, spikeinEx):
117117
continue
118118
return([hostl,spikeinl])
119119

120-
if useSpikeinForNorm:
120+
if useSpikeInForNorm:
121121
part=['host','spikein']
122122
spikein_detected=check_if_spikein_genome(genome_index,spikeinExt)
123123
if spikein_detected:
@@ -127,5 +127,5 @@ if useSpikeinForNorm:
127127
k, v = next(iter(spikein_chr.items()))
128128
spikein_region = ":0:".join([str(k),str(v)])
129129
else:
130-
print("\n useSpikeinForNorm was specified but no spikein genome was detected - no spikeIn chromosomes found with extention " + spikeinExt + " .\n\n")
130+
print("\n useSpikeInForNorm was specified but no spikein genome was detected - no spikeIn chromosomes found with extention " + spikeinExt + " .\n\n")
131131
exit(1)

tests/test_jobcounts.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -578,7 +578,7 @@ def test_spikein(self, ifs):
578578
'--snakemakeOptions',
579579
SMKOPTS,
580580
ifs / 'org.yaml',
581-
'--useSpikeinForNorm'
581+
'--useSpikeInForNorm'
582582
]
583583
print(' '.join([str(i) for i in ci]))
584584
_p = sp.run(ci, capture_output=True, text=True)
@@ -594,7 +594,7 @@ def test_whatshap_allelic_spikein(self, ifs):
594594
'--snakemakeOptions',
595595
SMKOPTS,
596596
ifs / 'org.yaml',
597-
'--useSpikeinForNorm',
597+
'--useSpikeInForNorm',
598598
'-m',
599599
'allelic-whatshap',
600600
'--phasedVcf',

0 commit comments

Comments
 (0)