Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds :append option to add values to the selection in :tags mode. #63

Closed
wants to merge 3 commits into from

Conversation

shamanime
Copy link
Contributor

This is motivated by our need to allow the user to add a preset list of values to a selection group at any moment without replacing already selected values.

This is the minimum code for it to work. Please let me know how it can be improved. :D

@maxmarcon
Copy link
Owner

Hi and sorry for replying so late... last months were extremely busy for me.

So, why can't we just do this:

send_update(LiveSelect.Component, id: live_select_id, value: current_selection ++ stuff_you_want_to_append)

I really want to keep the API lean and as minimal as possible (there's already too many options IMO) so if this gets the job done I'd rather stick with it.

@shamanime
Copy link
Contributor Author

Closed in favor of #68

@shamanime shamanime closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants